feat(jellyfish-api-core): add encryptWallet, walletPassphrase, walletPassphraseChange, walletLock RPC #1969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit a2c61fb and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
github-actions
bot
added
apps/website
area/packages
kind/feature
✅ Deploy Preview for jellyfishsdk ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov ReportBase: 90.74% // Head: 89.10% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1969 +/- ##
==========================================
- Coverage 90.74% 89.10% -1.64%
==========================================
Files 367 363 -4
Lines 10771 11027 +256
Branches 1376 1439 +63
==========================================
+ Hits 9774 9826 +52
- Misses 952 1146 +194
- Partials 45 55 +10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Docker build preview for jellyfish/apps is ready! Built with commit 66b16a8
You can also get an immutable image with the commit hash
|
shancht
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
/kind feature
Which issue(s) does this PR fixes?:
Fixes part of #48 by adding
encryptWallet()&walletPassphrase().encryptWallet()allows the encryption of wallet for the first time using a custom ‘passphrase’. Transactions and calls related to private keys will thereafter require a passphrase before execution.walletPassphrase()stores the wallet decryption key in memory for ‘timeout’ seconds. Calling 'walletpassphrase' when wallet is unlocked will set a new unlock time that overrides the old setting.Additional comments?:
Primary purpose is to add a layer of security towards the wallet in storing of private keys.